fix: apply cargo clippy fixes#4168
Closed
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Closed
Conversation
- Replace closure with function pointer: .map(|m| Arc::new(m)) -> .map(Arc::new) - Suppress too_many_arguments warning on spawn_download_task Co-Authored-By: unknown <>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two minor clippy fixes applied via
cargo clippy --fixand manual suppression:.map(|m| Arc::new(m))→.map(Arc::new)intranscribe-proxytoo_many_arguments: Added#[allow(clippy::too_many_arguments)]onspawn_download_task(8 params, limit is 7)Review & Testing Checklist for Human
#[allow(clippy::too_many_arguments)]suppression is acceptable vs. refactoringspawn_download_taskto use a params structNotes
tools,notch,tcc,notification-macos,cactus-sys,cactus) could not be checked by clippy on Linux due to macOS-only or ARM-only build dependencies. Those packages may have additional clippy warnings.